-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup in examples + fedora example #554
Conversation
Review status: 0 of 8 files reviewed at latest revision, 3 unresolved discussions. examples/cirros-vm-with-additional-annotations.yaml, line 51 at r1 (raw file): Quoted 7 lines of code…> # Virtlet currently ignores image tags, but their meaning may change > # in future, so it’s better not to set them for VM pods. If there’s no tag > # provided in the image specification kubelet defaults to > # imagePullPolicy: Always, which means that the image is always > # redownloaded when the pod is created. In order to make pod creation > # faster and more reliable, we set imagePullPolicy to IfNotPresent here > # so a previously downloaded image is reused if there is oneDo we need it there? Why not to put in in docs? Or at least make it shorter examples/fedora-vm-with-testuser.yaml, line 15 at r1 (raw file):
can we have info what PW is that in a comment? examples/ubuntu-vm-with-testuser.yaml, line 17 at r1 (raw file):
can we have plain text password as comment there? Comments from Reviewable |
It requires a fix in cloud init network data generation which will be included in separate commit.
530f45b
to
d8ec8d7
Compare
Review status: 0 of 10 files reviewed at latest revision, 3 unresolved discussions. examples/cirros-vm-with-additional-annotations.yaml, line 51 at r1 (raw file): Previously, pigmej (Jędrzej Nowak) wrote…
Done. examples/fedora-vm-with-testuser.yaml, line 15 at r1 (raw file): Previously, pigmej (Jędrzej Nowak) wrote…
Done. examples/ubuntu-vm-with-testuser.yaml, line 17 at r1 (raw file): Previously, pigmej (Jędrzej Nowak) wrote…
Done. Comments from Reviewable |
Review status: 0 of 10 files reviewed at latest revision, 6 unresolved discussions. examples/fedora-vm-with-testuser.yaml, line 15 at r1 (raw file): Previously, jellonek (Piotr Skamruk) wrote…
Please see the note about 'testuser' for ubuntu below, also applies here examples/fedora-vm-with-testuser.yaml, line 15 at r2 (raw file):
the password is "testuser"examples/fedora-vm-with-testuser.yaml, line 19 at r2 (raw file):
see the note for ubuntu 'testuser' examples/ubuntu-vm-with-testuser.yaml, line 17 at r1 (raw file): Previously, jellonek (Piotr Skamruk) wrote…
ubuntu example used to have problem of ssh key being ignored because of this 'testuser', so it's only possible to ssh into it using password. It would be better specify examples/ubuntu-vm-with-testuser.yaml, line 17 at r2 (raw file):
the password is "testuser"Comments from Reviewable |
Reviewed 1 of 6 files at r2. examples/ubuntu-vm-with-testuser.yaml, line 17 at r1 (raw file): Previously, ivan4th (Ivan Shvedunov) wrote…
In fedora - even if you will specify ssh key - after loging in as root with it you are asked to connect as other user, so that's probably similar to what was in ubuntu. I will add Comments from Reviewable |
d8ec8d7
to
9d5280c
Compare
Review status: 0 of 10 files reviewed at latest revision, 6 unresolved discussions. examples/fedora-vm-with-testuser.yaml, line 15 at r1 (raw file): Previously, ivan4th (Ivan Shvedunov) wrote…
Done. examples/fedora-vm-with-testuser.yaml, line 15 at r2 (raw file): Previously, ivan4th (Ivan Shvedunov) wrote…
Done. examples/fedora-vm-with-testuser.yaml, line 19 at r2 (raw file): Previously, ivan4th (Ivan Shvedunov) wrote…
Done. examples/ubuntu-vm-with-testuser.yaml, line 17 at r1 (raw file): Previously, jellonek (Piotr Skamruk) wrote…
Ok, after setting Comments from Reviewable |
Review status: 0 of 10 files reviewed at latest revision, 6 unresolved discussions. examples/ubuntu-vm-with-testuser.yaml, line 17 at r2 (raw file): Previously, ivan4th (Ivan Shvedunov) wrote…
Done. Comments from Reviewable |
Review status: 0 of 10 files reviewed at latest revision, 3 unresolved discussions. Comments from Reviewable |
Reviewed 4 of 8 files at r1, 6 of 6 files at r2. Comments from Reviewable |
Please note that additional fedora example requires fix in cloud init network data generation (will be included in next PR).
This change is